merlimat opened a new pull request, #4757: URL: https://github.com/apache/bookkeeper/pull/4757
## Summary Part of [BP-69](https://issues.apache.org/jira/browse/BOOKKEEPER-XXXX) (SLF4J to slog migration). Converts the `stream/distributedlog/*` and `stream/*` modules to use [slog](https://github.com/merlimat/slog) for structured logging. Stacked with (but independent of) #4754 / #4755 / #4756 — includes the same minimal base scaffolding commit: 1. `BP-69 base: add slog dependency and LICENSE entries` — adds slog to root `pom.xml`, updates `LICENSE-*.bin.txt` files, and adds `lombok.config` for the `@CustomLog` annotation. 2. `BP-69: Convert stream module from SLF4J to slog` — the actual module conversion (213 files). ## Scope Modules converted: - `stream/bk-grpc-name-resolver` - `stream/clients/java/{all,base,kv}` - `stream/common` - `stream/distributedlog/{common,core,io/dlfs,protocol}` - `stream/server` - `stream/statelib` - `stream/storage/impl` - `stream/tests-common` ## Conversion patterns applied - `LoggerFactory.getLogger(Foo.class)` / `@Slf4j` → Lombok `@CustomLog` generating a slog `Logger`. - `log.info("text {} {}", a, b)` → `log.info().attr("nameA", a).attr("nameB", b).log("text")` — values become typed structured attributes. - `log.error("msg", exception)` → `log.error().exception(exception).log("msg")`. - Consistent attribute naming: `ledgerId`, `entryId`, `streamId`, `rangeId`, `logSegment`, `storageContainer`, `routingKey`, etc. - Removed placeholder-removal artifacts (dangling prepositions, gap punctuation, trailing colons). No changes to log output format — slog with the SLF4J backend produces equivalent output. ## Test plan - [ ] `mvn -pl stream/... compile` passes - [ ] `mvn -pl stream/... checkstyle:check` passes - [ ] Full CI matrix green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
