merlimat opened a new pull request, #4764: URL: https://github.com/apache/bookkeeper/pull/4764
## Summary Part of [BP-69](https://issues.apache.org/jira/browse/BOOKKEEPER-XXXX) (SLF4J → slog migration). Now that the codebase has fully moved to the external `io.github.merlimat.slog:slog` library, the legacy in-tree `bookkeeper-slogger` module is dead weight and is removed. ## What changed **Callsite conversion** — 14 files in `bookkeeper-server` (5 main, 9 test) converted from the legacy `org.apache.bookkeeper.slogger.Slogger` API to slog `Logger`: | Old | New | |---|---| | `new Slf4jSlogger(Foo.class)` | `Logger.get(Foo.class)` | | `slog.kv("k", v).info(Events.X)` | `log.info().attr("k", v).log("Phrase")` | | `slog.kv(...).error(Events.X, t)` | `log.error().exception(t).attr(...).log("Phrase")` | | `slogParent.kv("dir", d).ctx(Foo.class)` | `Logger.get(Foo.class).with().ctx(parent).attr("dir", d).build()` | | `Slogger.NULL` / `Slogger.CONSOLE` | `Logger.get(TestClass.class)` | **`Events` enum removed.** The 21 callsites that referenced `directentrylogger/Events.java` now use natural-English phrases inline (e.g. `Events.COMPACTION_ABORT_EXCEPTION` → `"Compaction aborted"`, `Events.LOG_ROLL` → `"Rolling to new log file"`). The token-style enum names were a Slogger-era convention; slog event names live in the message text alongside the structured attrs. **Module removal:** - Deleted `bookkeeper-slogger/` directory tree (api + slf4j-bridge + tests). - Removed `<module>bookkeeper-slogger</module>` from root `pom.xml`. - Removed both `bookkeeper-slogger-api` / `bookkeeper-slogger-slf4j` deps from `bookkeeper-server/pom.xml`. ## Stats 34 files changed, +180 / −1549 lines. ## Test plan - [ ] `mvn -pl bookkeeper-server compile checkstyle:check` clean - [ ] All `Test*EntryLog*` / `Test*Direct*` / `GarbageCollectorThreadTest` tests pass (verified locally — 64/64) - [ ] Full CI matrix green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
