arimu1 opened a new pull request, #4889: URL: https://github.com/apache/bookkeeper/pull/4889
Fixes #4735 ### Motivation `RackawareEnsemblePlacementPolicy.onClusterChanged` forwards cluster updates to a slave policy when `networkTopologyStabilizePeriodSeconds > 0`. The implementation replaced the parent dead-bookie set with the slave return value, so a bookie removal could yield an empty set even though the parent (non-stabilized) policy had already detected the departure. ### Changes - Union the parent and slave dead-bookie sets in `onClusterChanged` instead of assigning over the parent result. - Update `testPlacementOnStabilizeNetworkTopology` to assert the removed bookie is reported as dead when stabilization is enabled. ### Test plan - [x] `JAVA_HOME=…/jdk-21 mvn -pl bookkeeper-server -Dtest=TestRackawareEnsemblePlacementPolicy#testPlacementOnStabilizeNetworkTopology test` Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
