henriquejsza opened a new pull request, #4919:
URL: https://github.com/apache/bookkeeper/pull/4919

   Fix #4603
   
   ### Motivation
   
   Log4j advises that libraries only add configuration files to their test
   classpath, so they do not override a downstream application's configuration 
via
   Log4j2 automatic configuration
   
(https://logging.apache.org/log4j/2.x/manual/configuration.html#automatic-configuration).
   
   The `bookkeeper-server` jar bundles `log4j2.xml` at its root
   (`bookkeeper-server/src/main/resources/log4j2.xml`). As reported, this file 
can
   be picked up by consumers such as Pulsar when their own module does not 
provide
   a configuration file.
   
   ### Changes
   
   - Move `log4j2.xml` from `bookkeeper-server/src/main/resources` to
     `bookkeeper-server/src/test/resources`. The console configuration is still
     used when running the module's tests, but the file is no longer packaged 
into
     the published artifact.
   
   The server distribution is unaffected: it loads `conf/log4j2.xml` (assembled
   from the top-level `conf` directory in `bookkeeper-dist` and referenced by
   `bin/common.sh`), not the jar-bundled file.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to