horizonzy opened a new pull request, #4924: URL: https://github.com/apache/bookkeeper/pull/4924
### Motivation An add can capture an ensemble before it is queued and miss an ensemble-change resend pass. A later no-op change, or a change affecting only another index, does not retry its missing writes when resend indices are derived only from ledger metadata. The stranded entry blocks subsequent completion callbacks and LAC advancement. Processing changed indices individually can also invoke completion callbacks for a write-set-external index before ACKs for other changed indices, or later pending entries, have been invalidated. ### Changes - Reconcile each pending operation against the target ensemble, including changes it missed before enqueueing. - Prepare the entire pending queue before resending: invalidate affected ACKs and remove their bookies from the successful-bookie set used for fault-domain checks. - Resend after preparation and explicitly advance callbacks afterward, including entries whose write sets did not change. - Add regression coverage for no-op changes, unrelated-index changes, multi-index ACK invalidation, late success/failure responses, successive ensemble reconciliation, and failures queued during an actual metadata ensemble change. ### Validation `mvn -pl bookkeeper-server -am -Dexec.skip=true -Dtest=PendingAddOpTest,LedgerHandleInlineReadTest -Dsurefire.failIfNoSpecifiedTests=false -DtestRetryCount=0 -Dspotbugs.skip test` All 12 selected tests passed on upstream master (7b66b5d763). Native build commands are skipped for this Java client change. Full-cluster and SpotBugs checks have not been run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
