This is an automated email from the ASF dual-hosted git repository. heneveld pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git
commit 27f11605f54e492f015692d4c1f054d7b0174aeb Author: Alex Heneveld <alex.henev...@cloudsoftcorp.com> AuthorDate: Thu Jan 24 12:47:49 2019 +0000 add comments for choosing images --- .../org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java b/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java index 4433e81..0a21a19 100644 --- a/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java +++ b/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java @@ -341,7 +341,12 @@ public class BrooklynImageChooser implements Cloneable { return ComparisonChain.start() .compare(left, right, primaryOrdering) // fall back to default strategy otherwise, except preferring *non*-null values - // TODO use AlphaNum string comparator + // TODO suggest to use NaturalOrderComparator (so 10>9) then order by: + // 1) `name.replaceAll("([^0-9]+)", " ")` + // 2) shortest non-empty name + // 3) version (NaturalOrderComparator, prefer last) + // 4) name (NaturalOrderComparator, prefer last) + // 5) other fields (NaturalOrderComparator, prefer last) .compare(left.getName(), right.getName(), Ordering.<String> natural().nullsFirst()) .compare(left.getVersion(), right.getVersion(), Ordering.<String> natural().nullsFirst()) .compare(left.getDescription(), right.getDescription(), Ordering.<String> natural().nullsFirst())