comment on url re-creating with stream handling
Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/692e47c9 Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/692e47c9 Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/692e47c9 Branch: refs/heads/master Commit: 692e47c99fe5f46162f8a4840434e013f85e163c Parents: c72fe8a Author: Alex Heneveld <[email protected]> Authored: Thu May 28 14:57:35 2015 +0100 Committer: Alex Heneveld <[email protected]> Committed: Thu May 28 14:58:01 2015 +0100 ---------------------------------------------------------------------- .../main/java/brooklyn/catalog/internal/CatalogClasspathDo.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/692e47c9/core/src/main/java/brooklyn/catalog/internal/CatalogClasspathDo.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/brooklyn/catalog/internal/CatalogClasspathDo.java b/core/src/main/java/brooklyn/catalog/internal/CatalogClasspathDo.java index a30a9dc..add0391 100644 --- a/core/src/main/java/brooklyn/catalog/internal/CatalogClasspathDo.java +++ b/core/src/main/java/brooklyn/catalog/internal/CatalogClasspathDo.java @@ -140,8 +140,7 @@ public class CatalogClasspathDo { // TODO potential disk leak above as we have no way to know when the temp file can be removed earlier than server shutdown; // a better way to handle this is to supply a stream handler (but URLConnection is a little bit hard to work with): -// URI uri = URI.create(classpath.getEntries().get(i)); -// urls[i] = new URL(uri.getScheme(), uri.getHost(), uri.getPort(), uri.getPath() // TODO query fragment? +// urls[i] = new URL(null, classpath.getEntries().get(i) // (handy construtor for reparsing urls, without splitting into uri first) // , new URLStreamHandler() { // @Override // protected URLConnection openConnection(URL u) throws IOException {
