ZipTask creates zip file with entries not sorted by path causing very slow 
unzipping.
-------------------------------------------------------------------------------------

                 Key: BUILDR-621
                 URL: https://issues.apache.org/jira/browse/BUILDR-621
             Project: Buildr
          Issue Type: Bug
          Components: Packaging
    Affects Versions: 1.4.7
            Reporter: Russell Teabeault


ZipTask#create_from iterates through the file_map and creates the zip with the 
entries in no particular order.  With a large zip file this can dramatically 
slow down unzipping since the physical disk has to do much more random access.  

Currently the code does:

{code:title=lib/buildr/packaging/ziptask.rb}
file_map.each do |path, content|
{code}

Doing something such as the following would probably be better:

{code:title=lib/buildr/packaging/ziptask.rb}
paths = file_map.keys.sort
paths.each do |path|
  content = file_map[path]
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to