[ 
https://issues.apache.org/jira/browse/BUILDR-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033204#comment-14033204
 ] 

Peter Donald commented on BUILDR-664:
-------------------------------------

Sounds like a better fix. Change applied in 
eb944e1547e8e9a31d59430c96be89c18364e285 - thanks!

> Checkstyle addon extra_dependencies should not include compile/test libs by 
> default
> -----------------------------------------------------------------------------------
>
>                 Key: BUILDR-664
>                 URL: https://issues.apache.org/jira/browse/BUILDR-664
>             Project: Buildr
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.4.10
>            Reporter: Dieter Vrancken
>            Assignee: Peter Donald
>            Priority: Minor
>
> The experimental Buildr::Checkstyle addon contains the following method:
>     def extra_dependencies
>         @extra_dependencies ||= [self.project.compile.dependencies, 
> self.project.test.compile.dependencies].flatten
>     end
> Also, checkstyle itself depends on an ancient version of google-collections 
> library.
> We were bitten by this in that our code depends on a newer version of the 
> guava library (successor to google-collections) in which a method used by 
> checkstyle has been removed.
> Since checkstyle does not require access to the runtime dependencies of the 
> code that is checked, I propose to make the default value of 
> @extra_dependencies empty: [].



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to