BuildStream-Migration-Bot opened a new pull request #1432: URL: https://github.com/apache/buildstream/pull/1432
[See original merge request on GitLab](https://gitlab.com/BuildStream/buildstream/-/merge_requests/2100) In GitLab by [[Gitlab user @tpollard]](https://gitlab.com/tpollard) on Nov 6, 2020, 16:55 This is related to https://gitlab.com/BuildStream/buildstream/-/issues/1313 In short, there are remote-exection usecases where server/worker implementations may incorporate custom/additional platform properties, or choose not to implement all/any of the 'optional' standard properties, as defined by the platform message lexicon: https://github.com/bazelbuild/remote-apis/blob/master/build/bazel/remote/execution/v2/platform.md - [x] Add tests (probably excessive running the full set of tests against multiple platform configurations?) - [ ] Add validation type filtering (no nesting etc) - [ ] Add support for multi value properties (i.e, ISA which needs support adding already even without this MR) - [ ] Cache Key considerations (when changing default properties which have previously constituted `get_unique_key()` for the sandbox config) This branch is being exercised with this remote-apis-testing MR https://gitlab.com/remote-apis-testing/remote-apis-testing/-/merge_requests/192 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
