gtristan commented on PR #1714: URL: https://github.com/apache/buildstream/pull/1714#issuecomment-1214926455
> [...] > That said, there is quite some code added to setup.py :) Adding support for custom version styles to versioneer would help us reduce that, but i didn't have time to dig into it. Not much of a concern really, I was mostly worried about betting on setup.py too heavily, but you've put my concerns to rest :) > > This will run CI on the wheels we upload only at tag/release time, which presents some workflow complexity > > Currently we test everything that is required when merging a commit to master, so we already know that CI will pass on a tag > > I don't think we want to build wheels and run CI on wheels for every merge to master, CI is already quite lengthy > > The PR currently runs wheel build + test on each merge to master. I thought the same thing that the release manager will not want to discover horrifically broken wheels only at the point on Friday night when they push a new tag. Great, I didn't notice from my reading of the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
