ssssam opened a new pull request, #1746: URL: https://github.com/apache/buildstream/pull/1746
If buildbox-run is missing, BuildStream falls back to "dummy" sandbox which allows the program to start, and causes build command execution to fail with a "missing sandbox" error. Previously, if buildbox-run was present but broken (e.g. segfaulting on startup), the same fallback codepath would be taken. This lead to serious breakage in the buildstream-docker-images going undetected: https://gitlab.com/BuildStream/buildstream-docker-images/-/issues/50 With this change, a broken buildbox-run leads to BuildStream failing on startup with an error such as this: Error instantiating platform: buildbox-run exited with code 5. Output: I am broken! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
