abderrahim commented on code in PR #41:
URL: 
https://github.com/apache/buildstream-plugins/pull/41#discussion_r1038992656


##########
src/buildstream_plugins/elements/meson.yaml:
##########
@@ -39,11 +39,11 @@ variables:
 
   meson: meson setup %{conf-root} %{build-dir} %{meson-args}
 
-  ninja: |
+  meson-build: |
     ninja -j ${NINJAJOBS} -C %{build-dir}

Review Comment:
   maybe rename NINJAJOBS as well? cmake uses JOBS iirc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to