germinolegrand commented on issue #1758: URL: https://github.com/apache/buildstream/issues/1758#issuecomment-1345523795
I dare not imply that. I did not test your PR because i'm a buildstream user only and i don't know how to build buildstream ; That is why i call that a "quick fix". I just wanted my installation (recently upgraded to Fedora 37) to work without waiting for your PR to land in a release available to me... Although, just by reading the code, i'm not sure it would be sufficient to upgrade yaml ; because buildstream/element.py does something that is deprecated since Python 3.6 : concatenate multiple regex expressions that have global flags like (?ms). My quick fix is a workaround, albeit a dirty one, not sure it is ok to put such a code in a production code base. Would be better either to ask yaml not to generate the flags, or ensure the newer yaml version does not generate them anymore, or to make sure it ALWAYS generates exactly "(?ms)" at the beginning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
