nanonyme commented on code in PR #1864: URL: https://github.com/apache/buildstream/pull/1864#discussion_r1326319322
########## src/buildstream/source.py: ########## @@ -749,9 +749,12 @@ def mark_download_url(self, url: str, *, primary: bool = True) -> None: if primary: expected_alias = _extract_alias(url) - assert ( - self.__expected_alias is None or self.__expected_alias == expected_alias - ), "Primary URL marked twice with different URLs" + if self.__expected_alias is not None and self.__expected_alias != expected_alias: + raise BstError( Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@buildstream.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org