nanonyme commented on PR #1901: URL: https://github.com/apache/buildstream/pull/1901#issuecomment-2011702834
> That said, even the immediate retry on UNAVAILABLE likely helps in some cases. The only thing, that I can think of, where this patch makes anything worse might be to not report the "Failed contacting remote execution server" in case of UNAVAILABLE being fatal (i.e., either it failed already before the first response of `Execute()` in which case there will be no retry, or the immediate retry fails as well). If `last_operation is None`, we should still raise that error, at least as long as we don't retry in that case. Can't we detect that it failed before first execute that running_operation is None? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
