juergbi commented on code in PR #60:
URL:
https://github.com/apache/buildstream-plugins/pull/60#discussion_r1553294151
##########
src/buildstream_plugins/sources/cargo.py:
##########
@@ -35,8 +35,8 @@
# Specify the cargo source kind
kind: cargo
- # Url of the crates repository to download from (default:
https://static.crates.io/crates)
- url: https://static.crates.io/crates
+ # Url of the crates repository to download from (default:
https://static.crates.io/crates/)
+ url: https://static.crates.io/crates/
Review Comment:
I've pushed this commit to improve backward compatibility:
https://github.com/apache/buildstream-plugins/commit/ce1624975749e5c760fe8a733911d2f4779e4c80
It appends a trailing slash to the specified URL if it doesn't already have
one and it's not just an alias (`foo:`). For `get_unique_key()` the unmodified
specified URL is used with the old default value to unbreak cache keys.
If just an alias is specified, it still requires the alias to resolve to a
URL with a trailing slash, but this might be as good as it gets with regards to
backard compatibility.
It passes CI but I'm not sure whether that's sufficient testing for cargo:
https://github.com/apache/buildstream-plugins/actions/runs/8567836966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
