abderrahim commented on code in PR #1918:
URL: https://github.com/apache/buildstream/pull/1918#discussion_r1599880901
##########
tests/frontend/mirror.py:
##########
@@ -895,9 +895,29 @@ def test_source_mirror_plugin(cli, tmpdir):
@pytest.mark.parametrize("unaliased_sources", [True, False])
@pytest.mark.parametrize("disallow_subproject_uris", [True, False])
@pytest.mark.parametrize("fetch_source", ["aliases", "mirrors"])
[email protected]("alias_override", [["foo"], ["foo", "bar"], "global",
"invalid"])
[email protected](
Review Comment:
This is mainly to be able to exclude some elements from the test matrix.
Initially I wanted something like
```
@pytest.mark.parametrize("alias_override", [["foo"], ["foo", "bar"],
"global"])
@pytest.mark.parametrize("alias_mapping", ["identity", "project-prefix",
"invalid"])
```
but "global,project-prefix" isn't implemented yet (I'd like to have it in a
future release) and "global,invalid" doesn't make sense.
As for the reason I'm doing this, the bug in question happens when having a
non-identity mapping along with source mirror plugin. When I started, I thought
it could be unrelated to source plugins, so wanted to test it.
If you have a better option, feel free to comment. Or I can add the above to
a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
