nanonyme commented on code in PR #66:
URL:
https://github.com/apache/buildstream-plugins/pull/66#discussion_r1605242847
##########
src/buildstream_plugins/sources/docker.py:
##########
@@ -387,22 +387,23 @@ def configure(self, node):
self.original_registry_url = node.get_str("registry-url",
_DOCKER_HUB_URL)
self.registry_url = self.translate_url(self.original_registry_url)
- if "ref" in node:
- self.digest = self._ref_to_digest(node.get_str("ref"))
- else:
- self.digest = None
self.tag = node.get_str("track", "") or None
self.architecture = node.get_str("architecture", "") or
default_architecture()
self.os = node.get_str("os", "") or default_os()
- if not (self.digest or self.tag):
- raise SourceError("{}: Must specify either 'ref' or 'track'
parameters".format(self))
Review Comment:
Plugin will not try to fetch anything because as said is_resolved returns
False.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
