abderrahim commented on code in PR #1921:
URL: https://github.com/apache/buildstream/pull/1921#discussion_r1686744823
##########
src/buildstream/element.py:
##########
@@ -2810,14 +2807,11 @@ def __sandbox(self, directory, stdout=None,
stderr=None, config=None, allow_remo
else:
output_node_properties = None
- if directory is not None and allow_remote and
context.remote_execution_specs:
-
- self.info("Using a remote sandbox for artifact {} with directory
'{}'".format(self.name, directory))
-
+ if allow_remote and context.remote_execution_specs:
+ self.info("Using a remote sandbox for artifact
{}".format(self.name))
Review Comment:
Yeah, it's very clear. You get "uploading build root" and "waiting for the
remote build to complete" as subtasks of "running commands".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
