juergbi commented on code in PR #81:
URL:
https://github.com/apache/buildstream-plugins/pull/81#discussion_r1872955092
##########
tests/sources/git.py:
##########
@@ -695,10 +695,11 @@ def test_track_invalid_submodule(cli, tmpdir, datafiles,
fail):
@pytest.mark.skipif(HAVE_GIT is False, reason="git is not available")
@pytest.mark.datafiles(os.path.join(DATA_DIR, "template"))
@pytest.mark.parametrize("ref_format", ["sha1", "git-describe"])
[email protected]("tag,extra_commit", [(False, False), (True, False),
(True, True)])
-def test_track_fetch(cli, tmpdir, datafiles, ref_format, tag, extra_commit):
[email protected]("tag_extra_commit", [(False, False), (True, False),
(True, True)])
+def test_track_fetch(cli, tmpdir, datafiles, ref_format, tag_extra_commit):
Review Comment:
In the buildstream repo I disabled `too-many-positional-arguments` in
`.pylintrc`. The reason was that the updated `pylint` split
`too-many-positional-arguments` from `too-many-arguments`. As we had the latter
already disabled, it seemed reasonable to disable the former as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
