nanonyme commented on code in PR #1754:
URL: https://github.com/apache/buildstream/pull/1754#discussion_r1901864148
##########
src/buildstream/utils.py:
##########
@@ -1260,14 +1254,7 @@ def _call(*popenargs, terminate=False, **kwargs):
process = None
- old_preexec_fn = kwargs.get("preexec_fn")
Review Comment:
I think with original functionality they probably could as caller preexec
was called *after* the preexec to set umask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
