nanonyme commented on PR #1989: URL: https://github.com/apache/buildstream/pull/1989#issuecomment-2660954359
> We're not merging this right now as it changes staging order and cache keys with all Python versions. #1993 solves the issue with Python 3.13 without changing cache keys for Python <= 3.12. > > A new algorithm, such as the one in this PR, may follow as optional alternative in the future. I agree, this solution does not seem acceptable. The more I've been reading, the nore it seems real solution needs to be topological sort. We actually want specific order from elements where dependencies are taken into account. It's not certain if Python 3.12 order is correct either. Python 3.11 changed sort function and after that all bets are off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
