gtristan commented on PR #1994: URL: https://github.com/apache/buildstream/pull/1994#issuecomment-2704595536
> I feel that cas-digest is too generic. This is actually the cas digest of the built artifact, we could (maybe not now, but in the future) have cas digests of other things (like the source code, or the buildtree if we have one) I tend to agree, while the “CAS” is an implementation detail it’s fairly well known, I think I’d rather avoid exposing the word in APIs if we don’t already have it. Also valid point about source caches. let’s use another name, perhaps `content-hash` ? Maybe that doesn’t capture the implication that it is the *artifact* content… maybe `output-hash` or `artifact-content-hash` ? Also, was this man page updated using the automated generation ? We should only update the command description in `cli.py` and use the python command to automatically update all the man pages and commit that as a separate commit… that command is documented… somewhere in our `HACKING` file(s)…. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
