juergbi commented on PR #2001: URL: https://github.com/apache/buildstream/pull/2001#issuecomment-2751153683
`mtime` capture is enabled only for elements with a workspace. Normal builds are neither affected by this change nor the buildbox-casd change. For workspace builds, the buildbox-casd change will result in a different CAS digest as directory mtimes are now captured as well. However, CAS digests of workspace builds are not deterministic anyway due to the file timestamps. What this change does is to apply the directory mtimes captured by recent casd to directories in `bst artifact checkout`. So the only noticeable difference should be when you checkout artifacts of workspace builds. It will restore the directory timestamps from the build, and I can't think of any negative side-effects of this in the context of workspace builds. And it fixes a test to work with old and new versions of buildbox-casd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
