gtristan commented on code in PR #87:
URL:
https://github.com/apache/buildstream-plugins/pull/87#discussion_r2070321863
##########
src/buildstream_plugins/sources/git.py:
##########
@@ -986,6 +1027,25 @@ def validate_cache(self):
warning_token=CoreWarnings.REF_NOT_IN_TRACK,
)
+ def collect_source_info(self):
+ #
+ # Currently we cannot implement version guessing, because we do not
save any tag
+ # information in the ref at tracking time.
+ #
+ # Also we do *not* support reporting on submodules, anyway as the
toplevel
+ # git repo determines the git commits of submodules, we consider the
toplevel
+ # git repo to be a comprehensive version of the overall input.
+ #
+ return [
+ self.create_source_info(
+ self.mirror.url,
+ SourceInfoMedium.GIT,
+ SourceVersionType.COMMIT,
+ self.mirror.ref,
Review Comment:
In buildstream-plugins-community, yes.
In buildstream-plugins, I'm unaware of the `git` plugin supporting a git
describe kind of value for the ref, even if you specified a describe string
instead of a raw sha, do you think/know that the git plugin, using host git,
would successfully `fetch()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
