gtristan opened a new pull request, #2008: URL: https://github.com/apache/buildstream/pull/2008
This fixes the issue of parsing typically formulated release tarball URLs. Consider the URL `https://flying-ponies.com/releases/1.2/pony-flight-1.2.3.tgz`. Without this change, we only get the version `1.2` (the directory where we put all of the `1.2` releases). After this change, we get `1.2.3`. This is achieved by explicitly supporting *optional groups* in the regex (which we already did, but in an not very specified way), and *preferring* more qualified matches by preferring *matches which had more groups present in the match* while iterating over all non-overlapping matches. By causing the user to explicitly specify *groups* in the regex, we avoid the pitfall of relying on silly things like string length (where both strings "1.200" and "1.2.3" would be considered *equally qualified*). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
