gtristan commented on code in PR #2018: URL: https://github.com/apache/buildstream/pull/2018#discussion_r2121030813
########## tests/frontend/source-info-unimplemented/fatal/elements/unimplemented.bst: ########## @@ -0,0 +1,4 @@ +kind: import + +sources: +- kind: fatal_unimplemented Review Comment: I should say I first considered generating the project.conf differently in the same directory but weighed the extra code against just having some separate files and decided on the latter, it's fairly arbitrary, while I have a slight preference for static test data over generated files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
