juergbi commented on code in PR #2019:
URL: https://github.com/apache/buildstream/pull/2019#discussion_r2185492751
##########
src/buildstream/_pluginfactory/pluginoriginpip.py:
##########
@@ -72,7 +72,7 @@ def get_plugin_paths(self, kind, plugin_type):
reason="package-not-found",
) from e
- if dist.version not in package.specifier:
+ if not package.specifier.contains(dist.version, prereleases=True):
Review Comment:
> What I consider to be different between pip and buildstream is that
buildstream doesn't install these packages. So if the user has already
installed a prerelease of buildstream-plugins-community, we should let them use
it rather than tell them, unhelpfully,
That makes sense to me. If we were to install packages, I would definitely
want to skip pre-releases by default. However, I don't think it's necessary to
reject pre-releases installed by the user as long as they still fulfill
versioning specifiers (if present). And as this was an unintentional change in
behavior, I'm in favor of restoring the previous behavior.
An extra flag for this could be discussed if there is a real use case where
the versioning specifiers are insufficient, but I don't consider that a blocker
for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
