gtristan commented on code in PR #2035: URL: https://github.com/apache/buildstream/pull/2035#discussion_r2199969264
########## src/buildstream/_frontend/inspect.py: ########## @@ -0,0 +1,184 @@ +import json +import sys + +from dataclasses import dataclass + +from ruamel.yaml import YAML + +from ..types import _Encoding, _ElementState, _PipelineSelection, _Scope + +# Inspectable Elements as serialized to the terminal +@dataclass +class _InspectElement: + name: str + description: str + workspace: any + key: str + key_full: str + state: str + environment: dict[str, str] + variables: dict[str, str] + artifact: any + dependencies: list[str] + build_dependencies: list[str] + runtime_dependencies: list[str] + sources: list[dict[str, str]] + +@dataclass +class _ProjectOutput: Review Comment: A lot of project related data missing here, such as which plugins have been loaded and their provenances, which cache servers were accessed, the provenance string of the project itself (i.e. which junction it was loaded from and where). All of which might not be reported by default. I think we should cover everything that is reported in `LogLine.print_heading()` - even if some of this data may be conditional (i.e. user config and access to caches may dictate which artifact/source remotes are active). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
