juergbi commented on code in PR #2031:
URL: https://github.com/apache/buildstream/pull/2031#discussion_r2200962544
##########
src/buildstream/sandbox/_sandboxbuildboxrun.py:
##########
@@ -148,7 +173,14 @@ def _execute_action(self, action, flags):
interactive=(flags & _SandboxFlags.INTERACTIVE),
)
- return
remote_execution_pb2.ActionResult().FromString(result_file.read())
+ action_result =
remote_execution_pb2.ActionResult().FromString(result_file.read())
+
+ if self.re_remote and context.remote_execution_specs.storage_spec and
context.remote_cache_spec:
+ # This ensures that the outputs are uploaded to the cache
storage-service
+ # in case different CAS remotes have been configured in the
`cache` and `remote-execution` sections.
Review Comment:
> Or is it due to the fact that buildbox-run can only take a single instance
for both the nested REAPI and where it stores its output? So it will upload its
output to the remote-execution CAS as well and we need to transfer it to the
cache CAS?
That's exactly the reason. While latest buildbox-run actually supports a
separate instance for nested REAPI, this is not currently configurable in
BuildStream (but it probably makes sense to add this configuration in a
follow-up).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
