abderrahim commented on code in PR #2033:
URL: https://github.com/apache/buildstream/pull/2033#discussion_r2200997625
##########
src/buildstream/sandbox/_sandboxremote.py:
##########
@@ -154,7 +154,7 @@ def run_remote_command(self, action_digest):
stub = self.exec_remote.exec_service
request = remote_execution_pb2.ExecuteRequest(
- instance_name=self.exec_remote.instance_name,
action_digest=action_digest, skip_cache_lookup=False
+ instance_name=self.exec_remote.instance_name,
action_digest=action_digest, skip_cache_lookup=True
Review Comment:
Yeah, even when the `action-cache-service` is defined, there is still value
in having the execution re-do cache lookup (in case the action is requested and
built by someone else before our action reaches the top of the queue).
You're right that this is probably working around a "broken" remote
execution server. I've only tested it with buildbox-casd, and wasn't aware it
was different with other servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
