juergbi commented on PR #2039: URL: https://github.com/apache/buildstream/pull/2039#issuecomment-3095456832
> Now that I'm seeing these `os.path.realpath()` calls popping up in the CPython code around "links", I wonder if this might effect symbolic links ? Surely it would be an absurd python bug if relative symbolic link targets ended up becoming absolute paths when extracted by `TarFile`, but it also looks like we don't have much coverage around symbolic links in tarball extraction in `tests/sources/tar.py`, so I'm not sure we would notice if such an absurd bug occurred. I've pushed a new test to verify that symlinks are supported and targets are not mangled. The new test passes without code changes. It would fail on Python 3.14 without `filter="tar"` (as `filter="data"` will be the new default), so it's certainly nice to have that covered in the test suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
