harrysarson opened a new issue, #2041:
URL: https://github.com/apache/buildstream/issues/2041

   The ordering used by `bst show --order alpha` is based on the comparison 
operator of the `Element` class. This ordering is based on element name only 
which means that the junction an element comes from is ignored when searching 
elements. This means that elements from different junctions get mixed together 
in the `bst show` output which is confusing.
   
   A better option might be to use `_get_full_name` as the sort key (either in 
the `def __lt__` in Element or directly in the `bst show` code). I am not sure 
on the stability promises of buildstream and whether the ordering of `alpha` 
cannot change (if so could we consider adding a new ordering?).
   
   ### References
   
   Comparison operator of `Element` class: 
https://github.com/apache/buildstream/blob/b8e6876d760641c2b6ccc3e2578eba48d0a33332/src/buildstream/element.py#L315-L316
   
   Sorting in `bst show`: 
https://github.com/apache/buildstream/blob/b8e6876d760641c2b6ccc3e2578eba48d0a33332/src/buildstream/_frontend/cli.py#L657-L658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to