juergbi commented on code in PR #2045:
URL: https://github.com/apache/buildstream/pull/2045#discussion_r2309679542
##########
src/buildstream/sandbox/_sandboxreapi.py:
##########
@@ -184,8 +184,12 @@ def _fetch_action_result_outputs(self, casremote,
action_result):
raise SandboxError("Output directory structure had no digest
attached.")
- # Fetch stdout and stderr blobs
- cascache.fetch_blobs(casremote, [action_result.stdout_digest,
action_result.stderr_digest])
+ # Fetch stdout and stderr blobs, if they exist
+ blobs = []
+ for digest in [action_result.stdout_digest,
action_result.stderr_digest]:
+ if digest.hash:
+ blobs.append(digest)
+ cascache.fetch_blobs(casremote, blobs)
Review Comment:
This PR looks reasonable incl. the above suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
