juergbi commented on code in PR #2060: URL: https://github.com/apache/buildstream/pull/2060#discussion_r2415742170
########## doc/source/handling-files/overlaps.rst: ########## @@ -144,6 +144,29 @@ command contain an ``rm`` statement, as such: This would cause later builds of ``runtime-only.bst`` to no longer conflict on the given file. +Changing the location Review Comment: > I guess we could just keep the section in BuildElement and refer to that from other documentation? Yes, I think it would be reasonable to add the information from this section to the `BuildElement` documentation as that's where `location` is documented. That said, the `BuildElement` documentation is a bit hidden as it's part of the Plugin API reference even though `location` is more relevant to project developers than plugin developers. I.e., maybe we could find a better place for the whole `location` documentation. However, moving that around is not directly related to expanding the documentation to cover the handling of runtime dependencies, so I suggest to first land the expanded documentation in `BuildElement` and then separately consider moving that section to a more relevant/discoverable part of the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
