aleixpol commented on PR #93: URL: https://github.com/apache/buildstream-plugins/pull/93#issuecomment-3397622344
https://github.com/apache/buildstream-plugins/issues/92 was fixed by @juergbi on a different layer, still I believe there's value in this change. I think there's still value here as it's simplifying and effectively using the cmake calls as they're meant to be used. Furthermore, addressing the comment by @abderrahim would be useful as having an effective "no changes allowed" policy in the project is dangerous for the project's health as it forces users to workaround it rather than to submit fixes upstream. I started a conversation here and in case it's something we can/want to address: https://lists.apache.org/thread/0z1679z3v9twl8yxgcyw94rsrz4l9roc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
