gtristan opened a new pull request, #2076:
URL: https://github.com/apache/buildstream/pull/2076

   The `Distribution` object returned by importlib.metadata.distribution() does 
not have a sensible `__str__()` dunder method to rely on. Instead we should be 
using `Distribution.name` and `Distribution.version` members to describe the 
pip package which was loaded in the plugin description string.
   
   This changes the following annoying output from `bst build` and other 
session commands:
   
   ```
       Source Plugins
           tar:      core plugin
           git_repo: junction: plugins/buildstream-plugins-community.bst 
(project directory: src/buildstream_plugins_community/sources)
           patch:    python package '<importlib.metadata.PathDistribution 
object at 0x7fc2d858cda0>' at: /usr/lib/python3.12/site-packages
   ```
   
   To the following, more satisfying output:
   
   ```
       Source Plugins
           tar:      core plugin
           git_repo: junction: plugins/buildstream-plugins-community.bst 
(project directory: src/buildstream_plugins_community/sources)
           patch:    python package 'buildstream-plugins' version 2.5.0 at: 
/usr/lib/python3.12/site-packages
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to