juergbi commented on code in PR #2098: URL: https://github.com/apache/buildstream/pull/2098#discussion_r2721290276
########## tests/frontend/source-info/elements/multisource.bst: ########## @@ -0,0 +1,7 @@ +kind: import + +sources: +- kind: multisource + ref: + - provenance: + homepage: https://flying-ponies.com/index.html Review Comment: I don't think this is used, is it? An additional test with a test plugin that uses provenance from `ref` could be useful, but specifying it here without being used is confusing. I consider such an additional test a blocker as nice-to-have but not a blocker. If you add such a test, please keep the current test using `Node.from_dict` as we want to make sure that a plugin can also programmatically create provenance information from non-ref metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
