juergbi commented on code in PR #2104:
URL: https://github.com/apache/buildstream/pull/2104#discussion_r2773973263
##########
src/buildstream/_stream.py:
##########
@@ -1828,7 +1828,6 @@ def _add_queue(self, queue, *, track=False):
def _enqueue_plan(self, plan, *, queue=None):
queue = queue or self.queues[0]
queue.enqueue(plan)
- self.session_elements += plan
Review Comment:
Ah, it's just a reference to the list created in `Stream`. I think
`set_session_elements()` threw me off as that doesn't actually set any
elements, it just passes a reference to the list. With clearer naming and/or
comment, it might be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
