joshua-zivkovic opened a new issue, #2106: URL: https://github.com/apache/buildstream/issues/2106
Generic source provenance, introduced in #2099, only allows support for singular string values. Fields such as [externalRefes](https://github.com/spdx/spdx-spec/blob/v2.3/schemas/spdx-schema.json#L313) and [attributionTexts](https://github.com/spdx/spdx-spec/blob/v2.3/schemas/spdx-schema.json#L353) should be arrays. BuildStream can't itself restrict types and not care about the attributes themselves without either: - Accepting everything as lists, strings are a single item - Allowing for user definition of types per field The former approach is simpler and *works* but offers no guarantee of correctness and is inaccurate for most cases whilst also tying BuildStream up in specifics instead of being generic. The latter approach is as accurate as users are but at the cost of a more complex implementation and verbose configs (not necessarily a bad thing other than to set up). There is also the option to simply not type check source provenance attributes at all but this would add more complexity to code such as `bst show` to potentially need to handle literally anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
