juergbi commented on code in PR #98:
URL: 
https://github.com/apache/buildstream-plugins/pull/98#discussion_r2811792973


##########
src/buildstream_plugins/sources/cargo.py:
##########
@@ -397,7 +420,14 @@ def preflight(self):
         return
 
     def get_unique_key(self):
-        return [self.original_url, self.cargo_lock, self.vendor_dir, self.ref]
+        return (
+            [
+                self.original_url,
+                self.cargo_lock,
+                self.vendor_dir,
+                self.ref,
+            ],
+        )

Review Comment:
   This changes the cache key (from list to one-tuple of a list). Is this an 
accidental change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to