juergbi commented on issue #1961: URL: https://github.com/apache/buildstream/issues/1961#issuecomment-4692575536
> Use BatchUpdateBlobs to send the data to buildbox-casd, composing batches of appropriate size. Since all the data is already in memory. Yes, I think that makes sense. `add_objects()` probably makes sense as is when `paths` are used but `BatchUpdateBlobs()` seems more sensible when the blobs are already in memory. > Use root_directory_digest instead of tree_digest from the output directories of an action result (we may need to set output_directory_format and servers are not required to support it) It sounds reasonable to add this as optimization but, as you mention, we can't rely on it. I would suggest we first implement the `BatchUpdateBlobs()` approach and then consider optional `root_directory_digest` support as optimization for servers that support it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
