juergbi commented on code in PR #2139:
URL: https://github.com/apache/buildstream/pull/2139#discussion_r3566591913
##########
src/buildstream/types.py:
##########
@@ -81,11 +81,14 @@ def __hash__(self):
return hash(id(self))
def __str__(self):
- return "{}.{}".format(self.__class__.__name__, self.name)
+ return str(self.name)
Review Comment:
Shouldn't this rather be the following to match `StrEnum`?
```suggestion
return str(self.value)
```
This would then also allow dropping `_PipelineSelection.__str__` as it would
be redundant.
##########
src/buildstream/_frontend/cli.py:
##########
@@ -960,7 +960,7 @@ def source_push(app, elements, deps, except_,
source_remotes, ignore_project_sou
@click.option(
"--deps",
"-d",
- default=_PipelineSelection.NONE,
+ default=(_PipelineSelection.NONE),
Review Comment:
```suggestion
default=str(_PipelineSelection.NONE),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
