wsalmonct commented on code in PR #2153:
URL: https://github.com/apache/buildstream/pull/2153#discussion_r3703031229
##########
src/buildstream/types.py:
##########
@@ -61,7 +64,7 @@ def __new__(cls, value):
try:
return cls._value_to_entry[value]
except KeyError:
- if type(value) is cls: # pylint: disable=unidiomatic-typecheck
+ if isinstance(value, cls): # pylint: disable=unidiomatic-typecheck
Review Comment:
AFAICT your are now doing this right.
https://pylint.pycqa.org/en/latest/user_guide/messages/convention/unidiomatic-typecheck.html
```suggestion
if isinstance(value, cls):
```
So you dont need to disable the lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
