juergbi commented on code in PR #2160:
URL: https://github.com/apache/buildstream/pull/2160#discussion_r3705380560
##########
src/buildstream/_cas/casremote.py:
##########
@@ -92,7 +94,16 @@ def send(self, *, missing_blobs=None):
local_cas = self._remote.casd.get_local_cas()
for request in self._requests:
- batch_response = local_cas.FetchMissingBlobs(request)
+ batch_response_future = local_cas.FetchMissingBlobs.future(request)
+
+ try:
+ while batch_response_future.running():
+ time.sleep(1)
+ except:
+ batch_response_future.cancel()
Review Comment:
As I understand it, this will typically not accomplish anything as
cancellation will only be possible before the function has started execution.
It might be as good as it gets without switching to gRPC AsyncIO, but I think
we should at least make this clear in a code comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
