juergbi commented on code in PR #2163:
URL: https://github.com/apache/buildstream/pull/2163#discussion_r3735590950


##########
pyproject.toml:
##########
@@ -23,6 +23,40 @@ requires = [
 ]
 build-backend = "setuptools.build_meta"
 
+[project]
+name = "BuildStream"
+dynamic = ["version", "dependencies"]
+description = "A framework for modelling build pipelines in YAML"
+readme = { file = "README.rst", content-type = "text/x-rst" }
+license = { text = "Apache License Version 2.0" }

Review Comment:
   Can we increase our minimum setuptools version to 77.0 and then switch to 
PEP 639? 
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files
   
   ```suggestion
   license = "Apache-2.0"
   ```
   
   And then we could drop the deprecated license classifier, fixing this 
warning, which has a deadline:
   
   ```
           Please use a simple string containing a SPDX expression for 
`project.license`. You can also use `project.license-files`. (Both options 
available on setuptools>=77.0.0).
   
           By 2027-Feb-18, you need to update your project and remove 
deprecated calls
           or your builds will no longer be supported.
   
           See 
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license 
for details.
   ```
   
   The latest maintenance releases of Python 3.10 and 3.11 already bundle 
setuptools 79.0 and more recent Python versions don't bundle setuptools at all 
anymore. Debian 12 (oldstable) and Ubuntu 22.04 and 24.04 still have older 
setuptools versions, but I don't know whether that would actually be a problem 
when installing BuildStream via pip.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to