abderrahim commented on code in PR #2166:
URL: https://github.com/apache/buildstream/pull/2166#discussion_r3903464385
##########
src/buildstream/_stream.py:
##########
@@ -1174,6 +1174,9 @@ def workspace_reset(self, targets, *, soft):
workspaces.save_config()
self.workspace_open([element._get_full_name()], no_checkout=False,
force=True, custom_dir=workspace_path)
+ if soft:
+ workspaces.save_config()
Review Comment:
I think it makes more sense (given the current code) to move this inside the
loop (under the existing `if soft:`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
