juergbi commented on code in PR #1424:
URL: https://github.com/apache/buildstream/pull/1424#discussion_r3989554605
##########
.pylintrc:
##########
@@ -26,58 +26,6 @@ extension-pkg-whitelist=
buildstream._yaml,
ujson
-# Add files or directories to the blacklist. They should be base names, not
-# paths.
-ignore=CVS,doc
Review Comment:
Removing this drops the `doc` ignore. Don't know whether that's actually
needed in some cases, but it's a potential change in behavior.
##########
.pylintrc:
##########
@@ -26,58 +26,6 @@ extension-pkg-whitelist=
buildstream._yaml,
ujson
-# Add files or directories to the blacklist. They should be base names, not
-# paths.
-ignore=CVS,doc
-
-# Add files or directories matching the regex patterns to the blacklist. The
-# regex matches against base names, not paths.
-ignore-patterns=.*_pb2.py,.*_pb2_grpc.py,.*.pyi
-
-# Python code to execute, usually for sys.path manipulation such as
-# pygtk.require().
-#init-hook=
-
-# Use multiple processes to speed up Pylint.
-jobs=1
-
-# List of plugins (as comma separated values of python modules names) to load,
-# usually to register additional checkers.
-load-plugins=
-
-# Pickle collected data for later comparisons.
-persistent=yes
-
-# Specify a configuration file.
-#rcfile=
-
-# Add paths to the list of the source roots. Supports globbing patterns. The
-# source root is an absolute path or a path relative to the current working
-# directory used to determine a package namespace for modules located under the
-# source root.
-source-roots=src
Review Comment:
This seems to be still needed.
##########
.pylintrc:
##########
@@ -148,401 +96,11 @@ disable=,
line-too-long,
superfluous-parens,
-
-# Enable the message, report, category or checker with the given id(s). You can
-# either give multiple identifier separated by comma (,) or put this option
-# multiple time (only on the command line, not in the configuration file where
-# it should appear only once). See also the "--disable" option for examples.
-enable=c-extension-no-member
-
+overgeneral-exceptions=builtins.Exception
Review Comment:
This should be moved back to the `[EXCEPTIONS]` section (or possibly
removed, the default might be ok).
##########
.pylintrc:
##########
@@ -26,58 +26,6 @@ extension-pkg-whitelist=
buildstream._yaml,
ujson
-# Add files or directories to the blacklist. They should be base names, not
-# paths.
-ignore=CVS,doc
-
-# Add files or directories matching the regex patterns to the blacklist. The
-# regex matches against base names, not paths.
-ignore-patterns=.*_pb2.py,.*_pb2_grpc.py,.*.pyi
-
-# Python code to execute, usually for sys.path manipulation such as
-# pygtk.require().
-#init-hook=
-
-# Use multiple processes to speed up Pylint.
-jobs=1
-
-# List of plugins (as comma separated values of python modules names) to load,
-# usually to register additional checkers.
-load-plugins=
-
-# Pickle collected data for later comparisons.
-persistent=yes
-
-# Specify a configuration file.
-#rcfile=
-
-# Add paths to the list of the source roots. Supports globbing patterns. The
-# source root is an absolute path or a path relative to the current working
-# directory used to determine a package namespace for modules located under the
-# source root.
-source-roots=src
-
-# Allow loading of arbitrary C extensions. Extensions are imported into the
-# active Python interpreter and may run arbitrary code.
-unsafe-load-any-extension=no
-
-
-[MESSAGES CONTROL]
Review Comment:
This section is still used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
