abderrahim commented on issue #2178: URL: https://github.com/apache/buildstream/issues/2178#issuecomment-5792277538
> Using `Directory` could be interesting, besides the built-in anti-escape mechanism, it potentially might allow to directly use `CasBasedDirectory` for subprojects instead of having to stage subprojects in the filesystem (but that would be a larger change, affecting more areas than element loading, if possible at all). I tried to do this at some point (with the goal of eventually using `CasBasedDirectory`). I tried to change all the interfaces between classes to use a FileBasedDirectory, even if they still use paths internally, to check if it's possible to use `Directory` without breaking the API. While It's mostly possible, there is `Source.get_project_directory()` which expects to return a filesystem path to the directory. If we want to use `CasBasedDirectory` at some point, we'll need a workaround for this. I'll try to find the draft and submit a PR at some point. But it might be a good idea to not wait for that to fix this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
